Introduce the @JavaStaticMethod and use it for calling static Java methods #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thods The use of the `@JavaMethod` macro within an extension of `JavaClass` to represent static Java methods on that class didn't quite work, because JavaClass is itself an AnyJavaObject with its own methods. Introduce a `@JavaStaticMethod` macro that will be used for this purpose, and have it call through a separate API (`dynamicJavaStaticMethodCall`). Thank you to Lokesh for reporting this bug!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the
@JavaMethodmacro within an extension ofJavaClasstorepresent static Java methods on that class didn't quite work, because
JavaClass is itself an AnyJavaObject with its own methods. Introduce
a
@JavaStaticMethodmacro that will be used for this purpose, andhave it call through a separate API (
dynamicJavaStaticMethodCall).Thank you to @lokesh-tr for reporting this bug!
As a bonus, unbreak the macOS build